Send patches - preferably formatted by git format-patch - to patches at archlinux32 dot org.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Gregory <andrew.gregory.8@gmail.com>2016-12-09 11:14:03 -0500
committerAllan McRae <allan@archlinux.org>2017-01-04 13:59:14 +1000
commit36eb35cacd9282fb063ed181b8754ef679ee302a (patch)
treeeb7f41c3d774ea50626b6d4db90ac7093b7499f5
parent2c4511bdbe3599713811e54edbbd60e51d66ce3e (diff)
makepkg: warn about dotfiles in package root
libalpm reserves paths starting with '.' for its own use and will not extract any other than those it recognizes. Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> Signed-off-by: Allan McRae <allan@archlinux.org>
-rw-r--r--scripts/Makefile.am1
-rw-r--r--scripts/libmakepkg/lint_package/dotfiles.sh.in38
-rw-r--r--scripts/po/POTFILES.in1
3 files changed, 40 insertions, 0 deletions
diff --git a/scripts/Makefile.am b/scripts/Makefile.am
index 41a9f5da..4bb08a24 100644
--- a/scripts/Makefile.am
+++ b/scripts/Makefile.am
@@ -58,6 +58,7 @@ LIBMAKEPKG_IN = \
libmakepkg/integrity/verify_signature.sh \
libmakepkg/lint_package.sh \
libmakepkg/lint_package/build_references.sh \
+ libmakepkg/lint_package/dotfiles.sh \
libmakepkg/lint_package/file_names.sh \
libmakepkg/lint_package/missing_backup.sh \
libmakepkg/lint_pkgbuild.sh \
diff --git a/scripts/libmakepkg/lint_package/dotfiles.sh.in b/scripts/libmakepkg/lint_package/dotfiles.sh.in
new file mode 100644
index 00000000..9842028c
--- /dev/null
+++ b/scripts/libmakepkg/lint_package/dotfiles.sh.in
@@ -0,0 +1,38 @@
+#!/bin/bash
+#
+# dotfiles.sh - check for dotfiles in the package root
+#
+# Copyright (c) 2016-2017 Pacman Development Team <pacman-dev@archlinux.org>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+
+[[ -n "$LIBMAKEPKG_LINT_PACKAGE_DOTFILES_SH" ]] && return
+LIBMAKEPKG_LINT_PACKAGE_DOTFILES_SH=1
+
+LIBRARY=${LIBRARY:-'@libmakepkgdir@'}
+
+source "$LIBRARY/util/message.sh"
+
+lint_package_functions+=('check_dotfiles')
+
+check_dotfiles() {
+ local ret=0
+ for f in "$pkgdir"/.*; do
+ [[ ${f##*/} == . || ${f##*/} == .. ]] && continue
+ error "$(gettext "Dotfile found in package root '%s'")" "$f"
+ ret=1
+ done
+ return $ret
+}
diff --git a/scripts/po/POTFILES.in b/scripts/po/POTFILES.in
index 4f47fc3b..7cc6a031 100644
--- a/scripts/po/POTFILES.in
+++ b/scripts/po/POTFILES.in
@@ -14,6 +14,7 @@ scripts/libmakepkg/integrity/verify_checksum.sh.in
scripts/libmakepkg/integrity/verify_signature.sh.in
scripts/libmakepkg/lint_package.sh.in
scripts/libmakepkg/lint_package/build_references.sh.in
+scripts/libmakepkg/lint_package/dotfiles.sh.in
scripts/libmakepkg/lint_package/file_names.sh.in
scripts/libmakepkg/lint_package/missing_backup.sh.in
scripts/libmakepkg/lint_pkgbuild.sh.in