buildmaster/build-list-links.php,buildmaster/build-list.php,buildmaster/build-slaves.php,buildmaster/deletion-links.php,buildmaster/dependencies.php,buildmaster/log.php,buildmaster/mysql-issues.php,buildmaster/statistics.php,buildmaster/todos.php,lib/format.php,mirrors/index.php,packages/index.php: isset($_GET[$x]) -> array_key_exists($x, $_GET)

1 files changed, 6 insertions, 6 deletions

diff --git a/buildmaster/dependencies.php b/buildmaster/dependencies.php
index a8beb5d..c513f2d 100644
--- a/buildmaster/dependencies.php
+++ b/buildmaster/dependencies.php
@@ -5,7 +5,7 @@ require_once BASE . "/lib/mysql.php";
 $match = "";
 
 function dependency_arch_join($name) {
-  if (isset($_GET["ba_a"])) {
+  if (array_key_exists("ba_a", $_GET)) {
     return
       " JOIN `architecture_compatibilities`" .
       " ON `architecture_compatibilities`.`fully_compatible`" .
@@ -13,7 +13,7 @@ function dependency_arch_join($name) {
       " JOIN `architectures` AS `ba_a`" .
       " ON `architecture_compatibilities`.`runs_on`=`ba_a`.`id`" .
       " AND `ba_a`.`name`=from_base64(\"" . base64_encode($_GET["ba_a"]) . "\")";
-  } elseif (isset($_GET["a"])) {
+  } elseif (array_key_exists("a", $_GET)) {
     return
       " JOIN `architecture_compatibilities` AS `ac_1`" .
       " ON `ac_1`.`fully_compatible`" .
@@ -26,13 +26,13 @@ function dependency_arch_join($name) {
     return "";
 }
 
-if (isset($_GET["a"]))
+if (array_key_exists("a", $_GET))
   $match .= " AND `architectures`.`name`=from_base64(\"" . base64_encode($_GET["a"]) . "\")";
-if (isset($_GET["b"]))
+if (array_key_exists("b", $_GET))
   $match .= " AND `package_sources`.`pkgbase`=from_base64(\"" . base64_encode($_GET["b"]) . "\")";
-if (isset($_GET["p"]))
+if (array_key_exists("p", $_GET))
   $match .= " AND `binary_packages`.`pkgname`=from_base64(\"" . base64_encode($_GET["p"]) . "\")";
-if (isset($_GET["r"]))
+if (array_key_exists("r", $_GET))
   $match .= " AND `repositories`.`name`=from_base64(\"" . base64_encode($_GET["r"]) . "\")";
 
 $ignore_install_targets = " AND NOT `install_targets`.`name` IN (\"base\",\"base-devel\")";