From 737596f038590878d9ac73e6e8de01ad22b2b340 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Wed, 30 May 2018 22:50:25 -0400 Subject: makepkg: do not chmod $BUILDDIR itself after checking for its existence In commit d8717a6a9666ec80c8645d190d6f9c7ab73084ac the write permission checks were refactored. Initially we intended to drop this chmod in the process, but due to some confusion about whether it was needed, I ended up submitting patches both to preserve and to remove it... but it's not needed after all. We do it on the individual $srcdir/$pkgdir, later on. Then, we used the wrong version, which causes unnecessary restrictions. See FS#58790 Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae --- scripts/makepkg.sh.in | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 9e4e5623..0e9da464 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -1371,7 +1371,6 @@ if ! ensure_writable_dir "BUILDDIR" "$BUILDDIR"; then plain "$(gettext "Aborting...")" exit $E_FS_PERMISSIONS fi -chmod a-s "$BUILDDIR" if (( ! (NOBUILD || GENINTEG) )) && ! ensure_writable_dir "PKGDEST" "$PKGDEST"; then plain "$(gettext "Aborting...")" -- cgit v1.2.3-70-g09d2