From 9a29f624f124b9e33e530a7fd4d7543f68977c2f Mon Sep 17 00:00:00 2001 From: Eric Bélanger Date: Thu, 23 Jun 2011 19:45:39 -0400 Subject: checkpkg: Clean up soname check output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A missing quote in a grep command was giving out false matches. By moving the objdump command in the same echo statement as the filename, we ensure that every library name are displayed on a line of their own in case they don't have a SONAME defined in their headers. That is the case for some plugin libraries. Signed-off-by: Eric Bélanger Signed-off-by: Pierre Schmitz --- checkpkg | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'checkpkg') diff --git a/checkpkg b/checkpkg index f8867bd..c349795 100755 --- a/checkpkg +++ b/checkpkg @@ -87,9 +87,8 @@ for _pkgname in ${pkgname[@]}; do mkdir -p pkg cd pkg bsdtar xf ../"$pkgfile" > /dev/null - for i in $(diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep \.so | awk '{print $2}'); do - echo -n "${i}: " - objdump -p $i | grep SONAME + for i in $(diff ../filelist-$_pkgname-old ../filelist-$_pkgname | grep \> | grep '\.so' | awk '{print $2}'); do + echo "${i}: " "$(objdump -p $i | grep SONAME)" done cd .. else -- cgit v1.2.3-70-g09d2