Age | Commit message (Collapse) | Author |
|
File: lib/disk.py
When installing on a loopback device (a.k.a loop device), function
Filesystem.partuuid_to_index() crashes with a JSON parsing error.
REASON
1) For loop devices, the property BlockDevice.device returns the
actual image file (back-file) of the loop device instead of the
/dev/X device.
2) Function Filesystem.partuuid_to_index() executes `lsblk --json`
against BlockDevice.device .
3) `lsblk` fails and prints the error "not a block device" to stderr.
This causes the output to not be valid JSON.
4) Code crashes when JSON parser tries to parse the output.
SOLUTION
- Make sure property BlockDevice.device only returns a valid block
device.
- Create new function BlockDevice.device_or_backfile that mimics
the present behaviour of BlockDevice.device.
- Use BlockDevice.device_or_backfile in function
BlockDevice.__repr__().
SOLUTION REASONING
I can only see one reason behind BlockDevice.device returning
the back-file of a loop device, and that is to show the back-file
to the user (instead of /dev/X) when printing the string
representation of a BlockDevice.
All other parts of the code can use the /dev/X file just fine.
And IMO it makes more sense that a property named `device` only
returns devices, and not normal files.
|
|
File: lib/user_interaction.py
When function manage_new_and_existing_partitions() is used, and
no partitions are configured, and 'Set desired filesystem for a
partition' is selected, the installer crashes.
|
|
File: lib/user_interaction.py
When function manage_new_and_existing_partitions() is used, and
'Suggest partition layout' is selected, the partition info is not
correctly stored in the config.
Instead of: {"partitions": [{...}, {...}]}
You get: {"partitions": {"partitions": [{...}, {...}], "wipe":True}}
|
|
Bug affects normal interactive usage (example/guided.py).
The timezone configured in the installer is not the timezone that
ends up in the new installed system. Instead, the timezone
used in the host system (from where the installer is run) is the
one that finally ends up being used.
Reason: systemd-nspawn by default copies the host timezone into
the target. And systemd-nspawn is run when keyboard-layout is
changed (which is done after changing the timezone).
Solution: Add option `--timezone=off` to systemd-nspawn, which
hinders affecting the timezone in the target.
|
|
Update ReadMe document link
|
|
fix readthedocs link
|
|
|
|
Remove unused import of json
|
|
Refactor meminfo() to allow direct key access
|
|
Fix indentation with tabs instead of spaces
|
|
|
|
|
|
|
|
Re-work partitioning logic, introducing more granularity (and stability)
|
|
|
|
|
|
Refactor cpu data detection
|
|
|
|
|
|
Native cpu detection
|
|
|
|
Fix wrong default in kernels (guide.py)
|
|
fixed the git checkout non-existent branch
|
|
Typo
|
|
Remove lightdm packages from Deepin profile
|
|
Update hardware.py
|
|
I tweaked the optimized return of check_output. Worth mentioning that `check_output()` will raise an exception `subprocess.CalledProcessError: Command 'lscpu | grep AMD' returned non-zero exit status 1.`.
|
|
The old behavior of SysCommand was that exit codes raised an exception, which needed to be handled by each individual caller. We now utilize `.exit_code` instead to manually detect faulty commands and raise exceptions where needed.
|
|
Mention GNOME and KDE's soft dependency on NetworkManager in the installation process
|
|
|
|
Replace for loops with comprehensions
|
|
latest changes from master. For future PR's do create a patch-branch for upstream patches to avoid changes to your local repo.
|
|
created load_config() to load configuration
|
|
torxed-rework-partitioning
|
|
never be created on single devices.
|
|
flag on the correct partition. Perhaps there's a smarter way. I suspect parted can operate on a given partition ID, but haven't found the docs for it yet.
|
|
selection process.
|
|
|
|
|
|
Use cpuinfo() function rather than a subprocess.
|
|
|
|
|
|
|
|
|
|
Fix wrong default in kernels.
|
|
added some more debugging
|
|
It looks like the `torxed-v2.2.0` branch doesnt exist anymore and I assume its now just `v2.2.0` instead so I changed this command in Using a live ISO
|
|
reliable size-conversion that isn't limited to Gigabytes in free_space().
|
|
|
|
Fix a tiny typo
|