Command locales (second batch) (#886)

* flexibilize the definition of execution locale for OS commands executed via the SysCommand* interface.
Defined a storage argument which holds the default
Added functions to
unset the program own locales
reset to the program default locales
set a specific locale
A decorator to execute functions in the host locale environment

* rename decorator local_environ to host_locale_environ
created a simmetric decorator c_locale_environ, to make a routine work with the C locale whatever is set

* Correct definition of btrfs standard layout

* Added error handling

* Fixed issue where archinstall.Boot() would raise an exception in vain

* Added debugging for SysCommandWorker()

* Added some debugging

* Tweaking debug a bit

* Tweaking debug

* Adding more debug

* Adding more debug

* Removed some debugging

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Adding more debug

* Removed soem debugging

* Removed soem debugging

* Testing a revert

* Adding back the reverted change, adding lofile

* Redirecting stdout to /dev/null for testing (to avoid interrupting the fork)

* Reverted debug changes

* Testing os.system()

Co-authored-by: Anton Hvornum <anton@hvornum.se>

1 files changed, 97 insertions, 2 deletions

diff --git a/archinstall/lib/locale_helpers.py b/archinstall/lib/locale_helpers.py
index cbba8d52..b48c3bc4 100644
--- a/archinstall/lib/locale_helpers.py
+++ b/archinstall/lib/locale_helpers.py
@@ -1,10 +1,10 @@
 import logging
-from typing import Iterator, List
+from typing import Iterator, List, Callable
 
 from .exceptions import ServiceException
 from .general import SysCommand
 from .output import log
-
+from .storage import storage
 
 def list_keyboard_languages() -> Iterator[str]:
 	for line in SysCommand("localectl --no-pager list-keymaps", environment_vars={'SYSTEMD_COLORS': '0'}):
@@ -28,6 +28,101 @@ def list_locales() -> List[str]:
 		locales.reverse()
 		return locales
 
+def get_locale_mode_text(mode):
+	if mode == 'LC_ALL':
+		mode_text = "general (LC_ALL)"
+	elif mode == "LC_CTYPE":
+		mode_text = "Character set"
+	elif mode == "LC_NUMERIC":
+		mode_text = "Numeric values"
+	elif mode == "LC_TIME":
+		mode_text = "Time Values"
+	elif mode == "LC_COLLATE":
+		mode_text = "sort order"
+	elif mode == "LC_MESSAGES":
+		mode_text = "text messages"
+	else:
+		mode_text = "Unassigned"
+	return mode_text
+
+def reset_cmd_locale():
+	""" sets the cmd_locale to its saved default """
+	storage['CMD_LOCALE'] = storage.get('CMD_LOCALE_DEFAULT',{})
+
+def unset_cmd_locale():
+	""" archinstall will use the execution environment default """
+	storage['CMD_LOCALE'] = {}
+
+def set_cmd_locale(general :str = None,
+				charset :str = 'C',
+				numbers :str = 'C',
+				time :str = 'C',
+				collate :str = 'C',
+				messages :str = 'C'):
+	"""
+	Set the cmd locale.
+	If the parameter general is specified, it takes precedence over the rest (might as well not exist)
+	The rest define some specific settings above the installed default language. If anyone of this parameters is none means the installation default
+	"""
+	installed_locales = list_installed_locales()
+	result = {}
+	if general:
+		if general in installed_locales:
+			storage['CMD_LOCALE'] = {'LC_ALL':general}
+		else:
+			log(f"{get_locale_mode_text('LC_ALL')} {general} is not installed. Defaulting to C",fg="yellow",level=logging.WARNING)
+		return
+
+	if numbers:
+		if numbers in installed_locales:
+			result["LC_NUMERIC"] = numbers
+		else:
+			log(f"{get_locale_mode_text('LC_NUMERIC')} {numbers} is not installed. Defaulting to installation language",fg="yellow",level=logging.WARNING)
+	if charset:
+		if charset in installed_locales:
+			result["LC_CTYPE"] = charset
+		else:
+			log(f"{get_locale_mode_text('LC_CTYPE')} {charset} is not installed. Defaulting to installation language",fg="yellow",level=logging.WARNING)
+	if time:
+		if time in installed_locales:
+			result["LC_TIME"] = time
+		else:
+			log(f"{get_locale_mode_text('LC_TIME')} {time} is not installed. Defaulting to installation language",fg="yellow",level=logging.WARNING)
+	if collate:
+		if collate in installed_locales:
+			result["LC_COLLATE"] = collate
+		else:
+			log(f"{get_locale_mode_text('LC_COLLATE')} {collate} is not installed. Defaulting to installation language",fg="yellow",level=logging.WARNING)
+	if messages:
+		if messages in installed_locales:
+			result["LC_MESSAGES"] = messages
+		else:
+			log(f"{get_locale_mode_text('LC_MESSAGES')} {messages} is not installed. Defaulting to installation language",fg="yellow",level=logging.WARNING)
+	storage['CMD_LOCALE'] = result
+
+def host_locale_environ(func :Callable):
+	""" decorator when we want a function executing in the host's locale environment """
+	def wrapper(*args, **kwargs):
+		unset_cmd_locale()
+		result = func(*args,**kwargs)
+		reset_cmd_locale()
+		return result
+	return wrapper
+
+def c_locale_environ(func :Callable):
+	""" decorator when we want a function executing in the C locale environment """
+	def wrapper(*args, **kwargs):
+		set_cmd_locale(general='C')
+		result = func(*args,**kwargs)
+		reset_cmd_locale()
+		return result
+	return wrapper
+
+def list_installed_locales() -> List[str]:
+	lista = []
+	for line in SysCommand('locale -a'):
+		lista.append(line.decode('UTF-8').strip())
+	return lista
 
 def list_x11_keyboard_languages() -> Iterator[str]:
 	for line in SysCommand("localectl --no-pager list-x11-keymap-layouts", environment_vars={'SYSTEMD_COLORS': '0'}):